Re: [PATCH v2 1/4] dt-bindings: mrvl,mmp-timer: add clock

[Pavel Machek]

On Tue 2018-09-18 22:54:52, Lubomir Rintel wrote:
> The timer needs the timer clock to be enabled, otherwise it stops
> ticking.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Acked-by: Pavel Machek <pavel@xxxxxx>


> ---
> Changes since v1:
> - Made the clock optional, to keep compatibility with DTs without it
> 
>  Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
> index 9a6e251462e7..b8f02c663521 100644
> --- a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
> @@ -5,9 +5,13 @@ Required properties:
>  - reg : Address and length of the register set of timer controller.
>  - interrupts : Should be the interrupt number.
>  
> +Optional properties:
> +- clocks : Should contain a single entry describing the clock input.
> +
>  Example:
>  	timer0: timer@d4014000 {
>  		compatible = "mrvl,mmp-timer";
>  		reg = <0xd4014000 0x100>;
>  		interrupts = <13>;
> +		clocks = <&coreclk 2>;
>  	};

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature