Re: [PATCH v1 3/7] vfio: ap: AP Queue Interrupt structures definitions

[Pierre Morel]

On 02/11/2018 16:14, Tony Krowiak wrote:
> On 10/31/18 2:12 PM, Pierre Morel wrote:
> > We define all the structures we need to let GISA handle
> > the AP Queues Interrupt.

...

> > +struct aqic_gisa {
> > + uint8_t rzone;
> > + uint8_t izone;
> > +ÂÂÂ unsignedÂÂÂ ir:1;
> > +ÂÂÂ unsignedÂÂÂ reserved1:4;
> > +ÂÂÂ unsignedÂÂÂ gisc:3;
> > +ÂÂÂ unsignedÂÂÂ reserved2:6;
> > +ÂÂÂ unsignedÂÂÂ f:2;
> > +ÂÂÂ unsignedÂÂÂ reserved3:1;
> > +ÂÂÂ unsignedÂÂÂ gisao:27;
> > +ÂÂÂ unsignedÂÂÂ t:1;
> > +ÂÂÂ unsignedÂÂÂ isc:3;
> > +}Â __packed __aligned(8);
>
> This struct is redundant with the 'struct ap_qirq_ctrl'
> defined in arch/s390/include/asm/ap.h. That file also includes
> the asm for the ap_aqic function.

Exact.
My code is quite old and I forgot to adapt it to the new definitions.
I will do it for this, aqic, the inline assembler and the status.

Thanks,

Pierre

--
Pierre Morel
Linux/KVM/QEMU in BÃblingen - Germany