Re: [PATCH] efi: Fix debugobjects warning on efi_rts_work

[Ard Biesheuvel]

On 23 October 2018 at 18:43, Prakhya, Sai Praneeth
<sai.praneeth.prakhya@xxxxxxxxx> wrote:
>
>
>> -----Original Message-----
>> From: Waiman Long [mailto:longman@xxxxxxxxxx]
>> Sent: Tuesday, October 23, 2018 7:18 AM
>> To: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>> Cc: linux-efi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Prakhya, Sai
>> Praneeth <sai.praneeth.prakhya@xxxxxxxxx>; Waiman Long
>> <longman@xxxxxxxxxx>
>> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
>>
>> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler") converted efi_rts_work from an auto variable to a global variable.
>> However, when submitting the work, INIT_WORK_ONSTACK() was still used
>> causing the following complaint from debugobjects:
>>
>> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
>> annotated.
>>
>> Change the macro to just INIT_WORK() to eliminate the warning.
>>
>> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler")
>
> Thanks for fixing this :)
> Looks good to me.
>
> Regards,
> Sai

Thanks

Queued in efi/urgent (with Sai's ack)