Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA
From: Andy Shevchenko
Date: Mon Nov 05 2018 - 15:47:10 EST
On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart
<pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote:
>
>
> >>> We have this ("strange") lines over the drivers:
> >>>
> >>> config BAR
> >>> depends on FOO || FOO=n
> >>>
> >>> which guarantees that FOO will be not module when BAR is built-in.
> >> That's what I normally use, but I could not figure this one out.
> >> One problem is that SND_SOC_ALL_CODECS selects
> >> SND_SOC_HDAC_HDA, and SND_SOC_ALL_CODECS itself
> >> may be =m, causing the failure for
> >> SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH=y.
> >>
> >> It might work with a separate dummy symbol:
> >>
> >> config SND_SOC_HDAC_HDA_FORCE
> >> tristate
> >> depends on SND_SOC_ALL_CODECS != n
Forgot to mention that AFAIU above line is no-op in symbols which are hidden.
> >> default SND_SOC_INTEL_SKYLAKE
> >> select SND_SOC_HDAC_HDA
--
With Best Regards,
Andy Shevchenko