RE: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak
From: Anson Huang
Date: Tue Nov 06 2018 - 04:12:44 EST
Hi, Daniel
Best Regards!
Anson Huang
> -----Original Message-----
> From: Daniel Lezcano [mailto:daniel.lezcano@xxxxxxxxxx]
> Sent: 2018å11æ6æ 17:06
> To: Anson Huang <anson.huang@xxxxxxx>; tglx@xxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Cc: dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid
> resource leak
>
>
> Hi Anson,
>
> On 06/11/2018 02:38, Anson Huang wrote:
> > Hi, Daniel
> >
> > Best Regards!
> > Anson Huang
> >
> >> -----Original Message-----
> >> From: Daniel Lezcano [mailto:daniel.lezcano@xxxxxxxxxx]
> >> Sent: 2018å11æ5æ 21:35
> >> To: Anson Huang <anson.huang@xxxxxxx>; tglx@xxxxxxxxxxxxx;
> >> linux-kernel@xxxxxxxxxxxxxxx
> >> Cc: dl-linux-imx <linux-imx@xxxxxxx>
> >> Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree
> >> to avoid resource leak
> >>
> >> Hi Anson,
> >>
> >> On 05/11/2018 02:10, Anson Huang wrote:
> >>> kfree should be called to free resource in error path before return.
> >>>
> >>> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> >>> ---
> >>> drivers/clocksource/timer-imx-gpt.c | 8 ++++++--
> >>> 1 file changed, 6 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/drivers/clocksource/timer-imx-gpt.c
> >>> b/drivers/clocksource/timer-imx-gpt.c
> >>> index a3d6ccb..0f78b30 100644
> >>> --- a/drivers/clocksource/timer-imx-gpt.c
> >>> +++ b/drivers/clocksource/timer-imx-gpt.c
> >>> @@ -477,12 +477,16 @@ static int __init mxc_timer_init_dt(struct
> >> device_node *np, enum imx_gpt_type t
> >>> return -ENOMEM;
> >>>
> >>> imxtm->base = of_iomap(np, 0);
> >>> - if (!imxtm->base)
> >>> + if (!imxtm->base) {
> >>> + kfree(imxtm);
> >>> return -ENXIO;
> >>> + }
> >>>
> >>> imxtm->irq = irq_of_parse_and_map(np, 0);
> >>> - if (imxtm->irq <= 0)
> >>> + if (imxtm->irq <= 0) {
> >>> + kfree(imxtm);
> >>> return -EINVAL;
> >>> + }
> >>>
> >>> imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");
> >>
> >> Please convert to timer-of API.
> >
> > This patch mainly to fix the potential resource leak issue, for
> > converting to timer-of API, should I add another patch for it? Since
> > it is a different subject.
>
> Actually I was unclear. The patch is duplicating the kfree in the error path,
> usually a rollback routine should be provided.
>
> So instead of creating this rollback path, you can directly use the timer-of
> which contains the error check and rollback.
I understand the timer-of can save some code in timer driver, but current GPT
driver is kind of complicated in order to support so many i.MX platforms with
different GPT design, change it to timer-of will need some effort and I think we
can do it later. If the duplicating kfree in error path confuses you, I can change
it to rollback path you said. Below are 2 options in my mind:
1. add kfree to rollback path;
2. skip this patch, just apply 1/2 patch, and let me find some time to change GPT
driver using timer-of.
Which one do you prefer? Thanks.
Anson.
>
>
>
> --
>
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .linaro.org%2F&data=02%7C01%7Canson.huang%40nxp.com%7Cc675bb
> b2063b43c3be1508d643c715f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C636770919692475408&sdata=pHaN%2BBguQo2lmVJzLYXBJ
> 12l6DwX%2BxSXo9Bil9SwYxs%3D&reserved=0> Linaro.org â Open source
> software for ARM SoCs
>
> Follow Linaro:
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .facebook.com%2Fpages%2FLinaro&data=02%7C01%7Canson.huang%40
> nxp.com%7Cc675bbb2063b43c3be1508d643c715f3%7C686ea1d3bc2b4c6fa9
> 2cd99c5c301635%7C0%7C0%7C636770919692475408&sdata=EgyadNU
> A1XLncN5p90lkIIiiMgQ0CIO405biLpKszvE%3D&reserved=0> Facebook |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitt
> er.com%2F%23!%2Flinaroorg&data=02%7C01%7Canson.huang%40nxp.c
> om%7Cc675bbb2063b43c3be1508d643c715f3%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301635%7C0%7C0%7C636770919692475408&sdata=NIgQhAPZBh9
> jKcrvNrEY005pZpLZP8pWIVlKXslQ%2B5U%3D&reserved=0> Twitter |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .linaro.org%2Flinaro-blog%2F&data=02%7C01%7Canson.huang%40nxp.c
> om%7Cc675bbb2063b43c3be1508d643c715f3%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301635%7C0%7C0%7C636770919692475408&sdata=MCBh9dJbjN
> GtK6Vpsj3EfrF7OGBRAawA3jkCmZpgm0I%3D&reserved=0> Blog