Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

[Miguel Ojeda]

On Tue, Nov 6, 2018 at 11:02 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> allows adding the "inline" keyword to 'asm ("")' statements. The
> problem is that we're possibly redefining "inline" to
> "inline __attribute__((__always_inline__))" which makes the proposed:
>
>   asm volatile inline ("")
>
> (...)
>
> -#define inline inline
> -#define inline   inline
> -

It seems somehow your patch got underscores removed.

By the way, we have been re#defining the inline keyword since (at
least) 2003, and already in 2008 Ingo was commenting in a commit to
add the #ifdef to avoid it for x86. Is it still a good idea nowadays
that the minimum compiler is quite modern compare to a decade ago? Is
it still needed on non-x86 arches (they don't have it in the
defconfig)? Couldn't functions be marked as __always_inline if really
needed (as many are)?

By the way (x2): CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING is only ever
referenced in that #ifdef. May it be removed?

Cheers,
Miguel