Re: [PATCH v6 13/14] Documentation/x86: Rename and update intel_rdt_ui.txt

[Matthew Wilcox]

On Tue, Nov 06, 2018 at 07:53:05AM -0800, Matthew Wilcox wrote:
> > -This feature is enabled by the CONFIG_INTEL_RDT Kconfig and the
> > -X86 /proc/cpuinfo flag bits:
> > +This feature is enabled by the CONFIG_INTEL_RDT Kconfig(for Intel) or
> > +CONFIG_AMD_QOS(for AMD) and the X86 /proc/cpuinfo flag bits:
> 
> Now I'm curious why we have two different Kconfig options for the same
> feature.  I should go and read the other patches, I suppose.

Now that I've read through them, I find nowhere that the choices:

AMQ_QOS=y INTEL_RDT=n
AMD_QOS=n INTEL_RDT=y
AMD_QOS=y INTEL_RDT=y

have any difference to the resulting code.  Thus, this looks like a
vanity config option; please don't do this.  Rename the config option
to be vendor-neutral if you must, but please no new options unless
absolutely necessary.