Re: [PATCH] slab.h: Avoid using & for logical and of booleans

[Bart Van Assche]

On Tue, 2018-11-06 at 09:20 -0800, Alexander Duyck wrote:
+AD4 On Mon, Nov 5, 2018 at 4:32 PM Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 wrote:
+AD4 +AD4 
+AD4 +AD4 On Mon, 2018-11-05 at 16:11 -0800, Alexander Duyck wrote:
+AD4 +AD4 +AD4 If we really don't care then why even bother with the switch statement
+AD4 +AD4 +AD4 anyway? It seems like you could just do one ternary operator and be
+AD4 +AD4 +AD4 done with it. Basically all you need is:
+AD4 +AD4 +AD4 return (defined(CONFIG+AF8-ZONE+AF8-DMA) +ACYAJg (flags +ACY +AF8AXw-GFP+AF8-DMA)) ? KMALLOC+AF8-DMA :
+AD4 +AD4 +AD4         (flags +ACY +AF8AXw-GFP+AF8-RECLAIMABLE) ? KMALLOC+AF8-RECLAIM : 0+ADs
+AD4 +AD4 +AD4 
+AD4 +AD4 +AD4 Why bother with all the extra complexity of the switch statement?
+AD4 +AD4 
+AD4 +AD4 I don't think that defined() can be used in a C expression. Hence the
+AD4 +AD4 IS+AF8-ENABLED() macro. If you fix that, leave out four superfluous parentheses,
+AD4 +AD4 test your patch, post that patch and cc me then I will add my Reviewed-by.
+AD4 
+AD4 Actually the defined macro is used multiple spots in if statements
+AD4 throughout the kernel.

The only 'if (defined(' matches I found in the kernel tree that are not
preprocessor statements occur in Perl code. Maybe I overlooked something?

+AD4 The reason for IS+AF8-ENABLED is to address the fact that we can be
+AD4 dealing with macros that indicate if they are built in or a module
+AD4 since those end up being two different defines depending on if you
+AD4 select 'y' or 'm'.

>From Documentation/process/coding-style.rst:

Within code, where possible, use the IS+AF8-ENABLED macro to convert a Kconfig
symbol into a C boolean expression, and use it in a normal C conditional:

.. code-block:: c

	if (IS+AF8-ENABLED(CONFIG+AF8-SOMETHING)) +AHs
		...
	+AH0

Bart.