Re: [PATCH v2 10/11] ext4: remove useless brelse call in ext4_xattr_inode_update_ref()

From: Theodore Y. Ts'o
Date: Tue Nov 06 2018 - 17:49:59 EST


On Wed, Oct 31, 2018 at 12:58:46AM +0300, Vasily Averin wrote:
> brelse(iloc.bh) is useless here, it is always called with iloc.bh = NULL
>
> Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13
> cc: Tahsin Erdogan <tahsin@xxxxxxxxxx>
>
> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxxxxx>

Applied. I droppped the "Fixes" since it's really not needed for
stable kernel; this is really more of a cleanup. I used the commit
description:

ext4: remove unneeded brelse call in ext4_xattr_inode_update_ref()

- Ted