Re: [PATCH] Make JFFS2 endianness configurable

From: Nikunj Kela (nkela)
Date: Tue Nov 06 2018 - 20:09:34 EST


Thanks for input. I have posted another patch with mount option:

http://lists.infradead.org/pipermail/linux-mtd/2018-November/085252.html


On 11/2/18, 2:23 PM, "Richard Weinberger" <richard@xxxxxx> wrote:

Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker:
> > Make it a mount option and store the endianness mode in the super block.
>
> It's actually a mkfs option currently. I'm not sure how that factors in,
>
> from the mkfs.jffs2 man page,
>
> -l, --little-endian
> Create a little-endian JFFS2 image. Default is to make an image with the same endianness as the host.
>
> -b, --big-endian
> Create a big-endian JFFS2 image. Default is to make an image with the same endianness as the host.

As long this setting is not stored in the filesystem itself, it is useless.
IIRC it just controls the endianness setting for mkfs.jffs2's
t32() and t16() macros.

That's why I think of a mount option like "force_endian=".

Thanks,
//richard