Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected

[Greg KH]

On Mon, Oct 15, 2018 at 09:44:41PM +0200, Niklas Cassel wrote:
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
> 
> Because of this change, we now also need to depend on the same
> Kconfigs as QCOM_QMI_HELPERS depends on.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxxxxx>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> ---
> Hello Greg, Srini,
> 
> I'm sorry for this.
> (Although I'm a bit curious why 0-day test bot didn't catch this.)
> 
> Considering that I've just changed QCOM_QMI_HELPERS in:
> ccfb464cd106 ("soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs")
> which is currently in linux-next, and that this Kconfig should
> depend on the same Kconfigs as QCOM_QMI_HELPERS depends on,
> I chose to have this Kconfig match the QCOM_QMI_HELPERS that is
> currently in linux-next.

Really?  I do this and then I get this build error on x86:

drivers/slimbus/qcom-ngd-ctrl.c: In function âof_qcom_slim_ngd_registerâ:
drivers/slimbus/qcom-ngd-ctrl.c:1333:63: warning: dereferencing âvoid *â pointer
  data = of_match_node(qcom_slim_ngd_dt_match, parent->of_node)->data;
                                                               ^~
drivers/slimbus/qcom-ngd-ctrl.c:1333:63: error: request for member âdataâ in something not a structure or union


So I can't take this, something else must be wrong here...

thanks,

greg k-h