Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

From: Genki Sky
Date: Wed Nov 07 2018 - 16:26:50 EST


On Wed, 7 Nov 2018 13:18:19 -0800, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> From reading the thread it sounds like Guenter was not even super
> happy with that based on the principal that you wouldn't expect a
> kernel build to be doing write operations in your .git directory even
> if $objtree == $srctree

I see, thanks.

> In theory you could wrap it. If passing git with
> "--no-optional-locks" doesn't work you could fall back to the old
> code? That would mean only people with newer git would get your new
> feature and everyone else would stick with the pre-existing behavior.
>
> It does seem like any things like this should be done atop Guenter's
> revert. AKA: revert first to get things working the way that they
> were and then start talking about how to make it better.

Okay, it's trading one regression for another, but I guess it's clear
that yours is much more painful. Sorry to have held up progress here.
I'll back out of the discussion until this is reverted.