RE: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

[Anson Huang]

Hi, Fabio

Best Regards!
Anson Huang

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@xxxxxxxxx]
> Sent: 2018å11æ7æ 18:03
> To: Anson Huang <anson.huang@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha
> Hauer <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>;
> Fabio Estevam <fabio.estevam@xxxxxxx>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; linux-kernel
> <linux-kernel@xxxxxxxxxxxxxxx>; moderated list:ARM/FREESCALE IMX / MXC
> ARM ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; dl-linux-imx
> <linux-imx@xxxxxxx>
> Subject: Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support
> 
> Hi Anson,
> 
> On Wed, Nov 7, 2018 at 3:19 AM Anson Huang <anson.huang@xxxxxxx>
> wrote:
> 
> > +&fec2 {
> > +       pinctrl-0 = <&pinctrl_enet2>;
> > +       /delete-property/pinctrl-assert-gpios;
> 
> "pinctrl-assert-gpios" does not exist in mainline, so not sure why you are
> deleting it.

Regarding the fec2 settings in imx7d-sdb.dts, originally it uses Rev-A board (but some nodes are
using Rev-B board), in this patch, I clean up all the settings in imx7d-sdb.dts using Rev-B board,
so below is added to imx7d-sdb.dts for Rev-B board, and in imx7d-sdb-reva.dts I have to
delete it, since Rev-A board has no this pin.

-	pinctrl-0 = <&pinctrl_enet2>;
+	pinctrl-0 = <&pinctrl_enet2 &pinctrl_enet2_epdc0_en>;
+	pinctrl-assert-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;
 
Anson.