Re: [PATCH 2/5] mm: lower the printk loglevel for __dump_page messages

From: Anshuman Khandual
Date: Fri Nov 16 2018 - 06:57:31 EST




On 11/16/2018 02:00 PM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@xxxxxxxx>
>
> __dump_page messages use KERN_EMERG resp. KERN_ALERT loglevel (this is
> the case since 2004). Most callers of this function are really detecting
> a critical page state and BUG right after. On the other hand the
> function is called also from contexts which just want to inform about
> the page state and those would rather not disrupt logs that much (e.g.
> some systems route these messages to the normal console).
>
> Reduce the loglevel to KERN_WARNING to make dump_page easier to reuse
> for other contexts while those messages will still make it to the kernel
> log in most setups. Even if the loglevel setup filters warnings away
> those paths that are really critical already print the more targeted
> error or panic and that should make it to the kernel log.
>
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>