RE: [PATCH v8 09/13] arch/resctrl: Update the RESCTRL config parameter

[Moger, Babu]

Randy,

> -----Original Message-----
> From: linux-kernel-owner@xxxxxxxxxxxxxxx <linux-kernel-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Randy Dunlap
> Sent: Friday, November 16, 2018 3:18 PM
> To: Moger, Babu <Babu.Moger@xxxxxxx>; tglx@xxxxxxxxxxxxx;
> mingo@xxxxxxxxxx; bp@xxxxxxxxx; corbet@xxxxxxx;
> fenghua.yu@xxxxxxxxx; reinette.chatre@xxxxxxxxx; peterz@xxxxxxxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; akpm@linux-
> foundation.org
> Cc: hpa@xxxxxxxxx; x86@xxxxxxxxxx; mchehab+samsung@xxxxxxxxxx;
> arnd@xxxxxxxx; kstewart@xxxxxxxxxxxxxxxxxxx; pombredanne@xxxxxxxx;
> rafael@xxxxxxxxxx; kirill.shutemov@xxxxxxxxxxxxxxx; tony.luck@xxxxxxxxx;
> qianyue.zj@xxxxxxxxxxxxxxx; xiaochen.shen@xxxxxxxxx;
> pbonzini@xxxxxxxxxx; Singh, Brijesh <brijesh.singh@xxxxxxx>; Hurwitz,
> Sherry <sherry.hurwitz@xxxxxxx>; dwmw2@xxxxxxxxxxxxx; Lendacky,
> Thomas <Thomas.Lendacky@xxxxxxx>; luto@xxxxxxxxxx; joro@xxxxxxxxxx;
> jannh@xxxxxxxxxx; vkuznets@xxxxxxxxxx; rian@xxxxxxxxxxxx;
> jpoimboe@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v8 09/13] arch/resctrl: Update the RESCTRL config
> parameter
> 
> On 11/16/18 12:54 PM, Moger, Babu wrote:
> > CONFIG_RESCTRL will be used for both Intel and AMD to enable
> > Resource Control feature. Update the details and condition accordingly.
> >
> > Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> > ---
> >  arch/x86/Kconfig | 19 ++++++++++++++-----
> >  1 file changed, 14 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index 4aae7aba4d61..c5ef3afa89a6 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -448,13 +448,22 @@ config RETPOLINE
> >  config RESCTRL
> >  	bool "Resource Control feature support"
> >  	default n
> > -	depends on X86 && CPU_SUP_INTEL
> > +	depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
> >  	select KERNFS
> >  	help
> > -	  Select to enable resource allocation and monitoring which are
> > -	  sub-features of Intel Resource Director Technology(RDT). More
> > -	  information about RDT can be found in the Intel x86
> > -	  Architecture Software Developer Manual.
> > +	  Select to enable Resource Control feature support.
> > +
> > +	  These features are intended to provide the support for the
> allocation
> > +	  and monitoring the usage of certain system resources by one or
> more
> 
> 	  and monitoring of the usage
 
Sure. Will take care of this next revision.
> 
> > +	  processors.
> > +
> > +	  Intel refers this feature as Intel Resource Director Technology
> 
> 	        refers to this feature

Yes. Will take care.

> 
> > +	  (Intel(R) RDT). More information about RDT can be found in the
> > +	  Intel x86 Architecture Software Developer Manual.
> > +
> > +	  AMD refers this feature as AMD Platform Quality of Service(AMD
> QoS).
> 
> 	      refers to this feature

Sure. Will fix. Thanks for the comments.

> 
> > +	  More information about AMD QoS can be found in AMD64
> Technology
> > +	  Platform Quality of Service Extensions manual.
> >
> >  	  Say N if unsure.
> >
> >
> 
> 
> --
> ~Randy