Re: [Ksummit-discuss] [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile

[Leon Romanovsky]

On Fri, Nov 16, 2018 at 03:33:17AM -0800, Mauro Carvalho Chehab wrote:
> Em Thu, 15 Nov 2018 21:35:20 +0200
> Leon Romanovsky <leon@xxxxxxxxxx> escreveu:
>
> > On Thu, Nov 15, 2018 at 11:09:34AM -0800, Mauro Carvalho Chehab wrote:
> > > Em Thu, 15 Nov 2018 18:20:08 +0200
> > > Leon Romanovsky <leon@xxxxxxxxxx> escreveu:
> > >
> > > > On Thu, Nov 15, 2018 at 06:10:36AM -0800, Mauro Carvalho Chehab wrote:
> > > > > Em Thu, 15 Nov 2018 09:03:11 +0100
> > > > > Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> escreveu:
> > > > >
> > > > > > Hi Dan,
> > > > > >
> > > > > > On Thu, Nov 15, 2018 at 6:06 AM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> > > > > > > Document the basic policies of the libnvdimm subsystem and provide a
> > > > > > > first example of a Subsystem Profile for others to duplicate and edit.
> > > > > > >
> > > > > > > Cc: Ross Zwisler <zwisler@xxxxxxxxxx>
> > > > > > > Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> > > > > > > Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
> > > > > > > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> > > > > >
> > > > > > Thanks for your patch!
> > > > > >
> > > > > > > --- /dev/null
> > > > > > > +++ b/Documentation/nvdimm/subsystem-profile.rst
> > > > > >
> > > > > > > +Trusted Reviewers
> > > > > > > +-----------------
> > > > > > > +Johannes Thumshirn
> > > > > > > +Toshi Kani
> > > > > > > +Jeff Moyer
> > > > > > > +Robert Elliott
> > > > > >
> > > > > > Don't you want to add email addresses?
> > > > > > Only the first one is listed in MAINTAINERS.
> > > > >
> > > > > IMO, it makes sense to have their e-mails here, in a way that it could
> > > > > easily be parsed by get_maintainers.pl.
> > > >
> > > > I personally think that list of "trusted reviewers" makes more harm than
> > > > good. It creates unneeded negative feelings to those who wanted to be in
> > > > this list, but for any reason they don't. Those reviewers will feel
> > > > "untrusted".
> > >
> > > Yeah, perhaps something like "most active reviewers" would sound
> > > better.
> >
> > I would recommend to remove this section at all.
> > New maintainers won't come out of blue, but will be come
> > from existing community and such individuals for sure will see
> > and judge by themselves to whom they trust and to whom not.
>
> I see your point, but, on the other hand, having a list with the ones
> that are actively doing reviews helps newcomers.
>
> I would keep, but perhaps it makes sense to add some notice about a
> criteria about how to be included at the "active reviewers" list,
> (the criteria probably belongs to the subsystem profile), e. g.
> something like:
>
> 	"Active reviewers are developers that contribute with more than 25
> 	 patches per year and do more than 50 reviews per year on
> 	 on patches written for drivers that they're not usual contributors"

Someone will need to maintain it and it looks to me like over complication.
I think that get_maintainer.pl already provides at least part of needed
information, but definitely not in very intuitive way.

It is worth to document get_maintainers.pl and update it to create the
list of "trusted reviewers".

Thanks

> Cheers,
> Mauro

Attachment: signature.asc
Description: PGP signature