Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

From: Stefan Wahren
Date: Sun Nov 18 2018 - 10:56:22 EST


Hi Nicolas,

> Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> hat am 14. November 2018 um 13:59 geschrieben:
>
>
> Hi All,
>
> This series was written in parallel with reading and understanding the
> vchiq code. So excuse me for the lack of logic in the sequence of
> patches.
>
> The main focus was to delete as much code as possible, I've counted
> around 550 lines, which is not bad. Apart from that there are some
> patches enforcing proper kernel APIs usage.
>
> The only patch that really changes code is the
> vchiq_ioc_copy_element_data() rewrite.
>
> The last commit updates the TODO list with some of my observations, I
> realise some of the might be a little opinionated. If anything it's
> going to force a discussion on the topic, which is nice.
>
> It was developed on top of the latest linux-next, and was tested on a
> RPIv3B+ with audio, video and running vchiq_test.
>
> Regards,
> Nicolas
>

without a changelog i won't start a review.

Regards
Stefan