Re: a9f38e1dec ("floppy: convert to blk-mq"): INFO: task mount:661 blocked for more than 120 seconds.

From: Jens Axboe
Date: Sun Nov 18 2018 - 22:06:31 EST


On 11/17/18 7:39 PM, kernel test robot wrote:
> Greetings,
>
> 0day kernel testing robot got the below dmesg and the first bad commit is
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>
> commit a9f38e1dec107af70d81338332494bf0a1e76597
> Author: Omar Sandoval <osandov@xxxxxx>
> AuthorDate: Mon Oct 15 09:21:34 2018 -0600
> Commit: Jens Axboe <axboe@xxxxxxxxx>
> CommitDate: Tue Oct 16 09:50:14 2018 -0600
>
> floppy: convert to blk-mq
>
> This driver likes to fetch requests from all over the place, so make
> queue_rq put requests on a list so that the logic stays the same. Tested
> with QEMU.
>
> Signed-off-by: Omar Sandoval <osandov@xxxxxx>
>
> Converted to blk_mq_init_sq_queue() and fixed a few spots where the
> tag_set leaked on cleanup.
>
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>

This should be fixed by:

commit de7b75d82f70c5469675b99ad632983c50b6f7e7
Author: Jens Axboe <axboe@xxxxxxxxx>
Date: Fri Nov 9 15:58:40 2018 -0700

floppy: fix race condition in __floppy_read_block_0()

which isn't in the tree that you tested. It's in -rc3, and in Linus's
tree since:

commit 59749c2d49bf28df69ac4bcabf1f69b00d3dca59
Merge: 9b5f361ac4a9 8dc765d438f1
Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Fri Nov 16 09:31:59 2018 -0600

Merge tag 'for-linus-20181115' of git://git.kernel.dk/linux-block

--
Jens Axboe