Re: [PATCH] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()

[Dave Hansen]

On 11/19/18 7:06 AM, Sebastian Andrzej Siewior wrote:
> On 2018-11-19 07:04:35 [-0800], Dave Hansen wrote:
>> Does the local_bh_disable() itself survive?
> Not in __fpu__restore_sig(). I do have:
> | static inline void __fpregs_changes_begin(void)
> | {
> |        preempt_disable();
> |        local_bh_disable();
> | }
> 
> and __fpregs_changes_begin() is introduced as part of the series.

OK, so can we just comment *that*, please?  Basically, why do we need botj?