Re: [PATCH 04/16] arm: dts: Add devicetree for RDA8810PL SoC

[Rob Herring]

On Mon, Nov 19, 2018 at 11:11 AM Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:
>
> Add initial device tree for RDA8810PL SoC from RDA Microelectronics.
>
> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
>  arch/arm/boot/dts/rda8810pl.dtsi | 95 ++++++++++++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 arch/arm/boot/dts/rda8810pl.dtsi
>
> diff --git a/arch/arm/boot/dts/rda8810pl.dtsi b/arch/arm/boot/dts/rda8810pl.dtsi
> new file mode 100644
> index 000000000000..7f1ff2021eff
> --- /dev/null
> +++ b/arch/arm/boot/dts/rda8810pl.dtsi
> @@ -0,0 +1,95 @@
> +/*
> + * RDA8810PL SoC
> + *
> + * Copyright (c) 2017 Andreas FÃrber
> + * Copyright (c) 2018 Manivannan Sadhasivam
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)

Goes on 1st line. checkpatch.pl will tell you this.

> + */
> +
> +/ {
> +       compatible = "rda,8810pl";
> +       #address-cells = <1>;
> +       #size-cells = <1>;
> +
> +       aliases {
> +               serial0 = &uart0;
> +               serial1 = &uart1;
> +               serial2 = &uart2;
> +       };
> +
> +       cpus {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               cpu@0 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a5";
> +                       reg = <0x0>;
> +               };
> +       };
> +
> +       soc {

soc@0

> +               compatible = "simple-bus";
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +               ranges = <0x0 0x0 0x80000000>;
> +
> +               sram@100000 {
> +                       compatible = "mmio-sram";
> +                       reg = <0x100000 0x10000>;

Based on the address of this and everything else, perhaps you should
move this to the top-level (or another bus node) and then either get
rid of the soc node level or make it start at 0x20000000. Kind of
depends on what the rest of the memory map looks like.

> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       ranges;
> +               };
> +
> +               apb@20800000 {
> +                       compatible = "simple-bus";
> +                       reg = <0x20800000 0x100000>;
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       ranges = <0x0 0x20800000 0x100000>;
> +               };
> +
> +               apb@20900000 {
> +                       compatible = "simple-bus";
> +                       reg = <0x20900000 0x100000>;

By definition of a simple-bus, it should not have any registers. Or
you should also have a specific compatible.

> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       ranges = <0x0 0x20900000 0x100000>;
> +               };
> +
> +               apb@20a00000 {
> +                       compatible = "simple-bus";
> +                       reg = <0x20a00000 0x100000>;
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       ranges = <0x0 0x20a00000 0x100000>;
> +
> +                       uart0: serial@0 {
> +                               compatible = "rda,8810pl-uart";
> +                               reg = <0x0 0x1000>;
> +                               status = "disabled";
> +                       };
> +
> +                       uart1: serial@10000 {
> +                               compatible = "rda,8810pl-uart";
> +                               reg = <0x10000 0x1000>;
> +                               status = "disabled";
> +                       };
> +
> +                       uart2: serial@90000 {
> +                               compatible = "rda,8810pl-uart";
> +                               reg = <0x90000 0x1000>;
> +                               status = "disabled";
> +                       };
> +               };
> +
> +               l2: cache-controller@21100000 {
> +                       compatible = "arm,pl310-cache";
> +                       reg = <0x21100000 0x1000>;
> +                       cache-unified;
> +                       cache-level = <2>;
> +               };
> +       };
> +};
> --
> 2.17.1
>