Re: [PATCH v2 4/5] mips: add system call table generation support

[Paul Burton]

Hi Firoz,

On Thu, Nov 15, 2018 at 11:44:20AM +0530, Firoz Khan wrote:
> diff --git a/arch/mips/kernel/syscalls/Makefile b/arch/mips/kernel/syscalls/Makefile
> new file mode 100644
> index 0000000..dc6bbb1
> --- /dev/null
> +++ b/arch/mips/kernel/syscalls/Makefile
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: GPL-2.0
> +kapi := arch/$(SRCARCH)/include/generated/asm
> +uapi := arch/$(SRCARCH)/include/generated/uapi/asm
> +
> +_dummy := $(shell [ -d '$(uapi)' ] || mkdir -p '$(uapi)')	\
> +	  $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)')
> +
> +syscallo32 := $(srctree)/$(src)/syscall_o32.tbl
> +syscall64 := $(srctree)/$(src)/syscall_64.tbl
> +syscalln32 := $(srctree)/$(src)/syscall_n32.tbl
> +syshdr := $(srctree)/$(src)/syscallhdr.sh
> +systbl := $(srctree)/$(src)/syscalltbl.sh

Could we go with 'n64' instead of just '64'?

When we get nanoMIPS support we'll be introducing the p32 ABI, and
there's a reasonable chance that the equivalent p64 ABI may come along
in the future. Using 'n64' now would avoid confusion in that case where
we may have 2 different 64-bit ABIs.

Thanks,
    Paul