Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page

From: William Kucharski
Date: Tue Nov 20 2018 - 23:52:00 EST




> On Nov 20, 2018, at 7:12 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote:
>
> + /*
> + * Check the locked pages before taking a reference to not
> + * go in the way of migration.
> + */

Could you make this a tiny bit more explanative, something like:

+ /*
+ * Check for a locked page first, as a speculative
+ * reference may adversely influence page migration.
+ */

Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>