Re: [PATCH v2 2/2] modpost: skip ELF local symbols by default during section mismatch check
From: Paul Walmsley
Date: Wed Nov 21 2018 - 12:52:57 EST
Hello Masahiro,
On Wed, 21 Nov 2018, Masahiro Yamada wrote:
I think this is almost good.
Just a nit.
Maybe, putting this check in secref_whitelist()
(with a comment "Pattern 6:")
could look more consistency.
Also, if you use strstart() helper,
you can remove is_local_symbol() function.
/* Check for pattern 6 */
if (strstarts(fromsym, ".L"))
return 0;
Thank you for your suggestion. This change is a definite improvement.
The patch has been updated, and I will repost the patch after it's been
tested.
Best regards,
- Paul