Re: [PATCH 2/3] dt-bindings: mfd: atmel-usart: add DMA bindings for SPI mode
From: Rob Herring
Date: Wed Nov 21 2018 - 15:52:44 EST
On Wed, Nov 21, 2018 at 10:48 AM Alexandre Belloni
<alexandre.belloni@xxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> On 21/11/2018 10:41:01-0600, Rob Herring wrote:
> > > +Optional properties in serial and SPI mode:
> > > +- dma bindings for dma transfer:
> > > + - dmas: DMA specifier, consisting of a phandle to DMA controller node,
> > > + memory peripheral interface and USART DMA channel ID, FIFO configuration.
> > > + Refer to dma.txt and atmel-dma.txt for details.
> > > + - dma-names: "rx" for RX channel, "tx" for TX channel.
> >
> > > + dma-names = "tx", "rx";
> >
> > The dma-names should have a defined order.
> >
>
> Why is that? Isn't the purpose of names to get rid of any particular
> ordering?
Because a fundamental rule of DT is the order is defined and
important. The purpose was to allow for cases that had a variable
number of entries, but even a variable number still have a defined
order.
Rob