Re: [PATCH v5] kernel/signal: Signal-based pre-coredump notification

From: Andrew Morton
Date: Wed Nov 21 2018 - 19:37:20 EST


On Tue, 30 Oct 2018 17:46:29 +0100 Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> On 10/29, Enke Chen wrote:
> >
> > Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx>
>
> Hmm. I didn't say this ;)
>
> But OK, feel free to keep this tag.
>
> I do not like this feauture.

Why is that?

> But I see no technical problems in this version
> and I never pretented I understand the user-space needs, so I won't argue.

The changelog appears to spell this all out quite well? Unusually
well, in my experience ;)

A couple of things...

- We'll be looking for a manpage update please. (Search MAINTAINERS
for "manpage")

- As it's a linux-specific feature, a test under
tools/testing/selftests would be appropriate. I don't know how much
that work will be. Do we have other linux-specific signal extensions
which could piggyback onto that?