Re: [PATCH] f2fs: read page index before freeing

From: Jaegeuk Kim
Date: Thu Nov 22 2018 - 07:02:26 EST


On 11/22, Chao Yu wrote:
> Hi Pan,
>
> On 2018/11/22 18:58, Pan Bian wrote:
> > The function truncate_node frees the page with f2fs_put_page. However,
> > the page index is read after that. So, the patch reads the index before
> > freeing the page.
>
> Good catch!

+1

>
> It will be better to add:
>
> Fixes: bf39c00a9a7f ("f2fs: drop obsolete node page when it is truncated")
> Cc: <stable@xxxxxxxxxxxxxxx>
>
> >
> > Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
>
> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Done.

>
> Thanks,