RE: [PATCH net-next v2 1/4] enetc: Introduce basic PF and VF ENETC ethernet drivers

[Claudiu Manoil]

>-----Original Message-----
>From: David Miller <davem@xxxxxxxxxxxxx>
>Sent: Thursday, November 22, 2018 2:21 AM
>To: Claudiu Manoil <claudiu.manoil@xxxxxxx>
>Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Alexandru
>Marginean <alexandru.marginean@xxxxxxx>; Catalin Horghidan
><catalin.horghidan@xxxxxxx>
>Subject: Re: [PATCH net-next v2 1/4] enetc: Introduce basic PF and VF ENETC
>ethernet drivers
>
>From: Claudiu Manoil <claudiu.manoil@xxxxxxx>
>Date: Tue, 20 Nov 2018 20:15:31 +0200
>
>> diff --git a/drivers/net/ethernet/freescale/Makefile
>b/drivers/net/ethernet/freescale/Makefile
>> index 3b4ff08..20e5c2f9 100644
>> --- a/drivers/net/ethernet/freescale/Makefile
>> +++ b/drivers/net/ethernet/freescale/Makefile
>> @@ -23,3 +23,4 @@ obj-$(CONFIG_FSL_FMAN) += fman/
>>  obj-$(CONFIG_FSL_DPAA_ETH) += dpaa/
>>
>>  obj-$(CONFIG_FSL_DPAA2_ETH) += dpaa2/
>> +obj-$(CONFIG_NET_VENDOR_FREESCALE) += enetc/
>
>The driver enable Kconfig option should guard traversing into the
>driver subdirectory, not the vendor enable Kconfig knob.

The enetc/ dir contains 2 drivers, that share a lot of common code.
Would you agree if I change the vendor enable with the two configs
(one for each driver) as below?

-obj-$(CONFIG_NET_VENDOR_FREESCALE) += enetc/
+obj-$(CONFIG_FSL_ENETC) += enetc/
+obj-$(CONFIG_FSL_ENETC_VF) += enetc/

Thanks,
Claudiu