Re: [PATCH AUTOSEL 4.9 09/15] ARM: make lookup_processor_type() non-__init

From: Russell King - ARM Linux
Date: Thu Nov 22 2018 - 19:04:53 EST


This, and your patch 11 aren't fixes on their own. They're part of a
rework for the "ARM: spectre-v2: per-CPU vtables to work around
big.Little systems" patch. It doesn't make sense to back port these
without that patch, even though they can be applied without.

On Thu, Nov 22, 2018 at 02:56:15PM -0500, Sasha Levin wrote:
> From: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
>
> [ Upstream commit 899a42f836678a595f7d2bc36a5a0c2b03d08cbc ]
>
> Move lookup_processor_type() out of the __init section so it is callable
> from (eg) the secondary startup code during hotplug.
>
> Reviewed-by: Julien Thierry <julien.thierry@xxxxxxx>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
> arch/arm/kernel/head-common.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
> index 8733012d231f..7e662bdd5cb3 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -122,6 +122,9 @@ __mmap_switched_data:
> .long init_thread_union + THREAD_START_SP @ sp
> .size __mmap_switched_data, . - __mmap_switched_data
>
> + __FINIT
> + .text
> +
> /*
> * This provides a C-API version of __lookup_processor_type
> */
> @@ -133,9 +136,6 @@ ENTRY(lookup_processor_type)
> ldmfd sp!, {r4 - r6, r9, pc}
> ENDPROC(lookup_processor_type)
>
> - __FINIT
> - .text
> -
> /*
> * Read processor ID register (CP#15, CR0), and look up in the linker-built
> * supported processor list. Note that we can't use the absolute addresses
> --
> 2.17.1
>

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up