Re: [PATCH 06/10] swiotlb: use swiotlb_map_page in swiotlb_map_sg_attrs

[Robin Murphy]

Hi Will,

On 2018-11-23 6:27 pm, Will Deacon wrote:
> Hi John,
>
> On Tue, Nov 20, 2018 at 10:25:16AM +0100, Christoph Hellwig wrote:
> > On Mon, Nov 19, 2018 at 03:22:13PM -0800, John Stultz wrote:
> > > > +               sg->dma_address = dma_addr;
> > > >                  sg_dma_len(sg) = sg->length;
> > > >          }
> > >
> > > I know Robin has already replied with more detailed info, but just to
> > > close the loop as I'm finally home, applying this patch didn't seem to
> > > help with the IO hangs I'm seeing w/ HiKey960.
> >
> > If Robins observation is right this should fix the problem for you:
>
> Please could you give this diff a try and let us know whether the problem
> persists with your board?

This is actually the exact same change that I ended up with in my 
fixes[1], which John has indeed confirmed.

(sorry, it's the thing I was telling you about the other day, but I 
neglected to include you on cc you when I sent the patches out the 
following morning)

Robin.

[1] https://lore.kernel.org/lkml/cover.1542812807.git.robin.murphy@xxxxxxx/