Re: [PATCH] locking/atomics: build atomic headers as required

From: Andrew Morton
Date: Fri Nov 23 2018 - 18:15:25 EST


On Fri, 23 Nov 2018 15:33:21 +0000 Mark Rutland <mark.rutland@xxxxxxx> wrote:

> Andrew and Ingo report that the check-atomics.sh script is simply too
> slow to run for every kernel build, and it's impractical to make it
> faster without rewriting it in something other than shell.
>
> Rather than committing the generated headers, let's regenerate these
> as-required for a pristine tree.
>
> That ensures they're always up-to-date, allows them to be built in
> parallel, and avoid redundant rebuilds, which is a 2-8s saving per
> incremental build. Since the results are not committed, it's very
> obvious that they should not be modified directly. If we need to
> generate more headers in future, it's easy to extend Makefile.genheader
> to permit this.
>
> I've verified that this works in the cases we previously had issues with
> (out-of-tree builds and where scripts have no execute permissions), and
> have tested these cases for both x86_64 and arm64.

Seems like a reasonable compromise. I'll take a copy for testing now,
shall drop that when this appears in tip->linux-next.