Re: linux-next: build warnings after merge of the cifs tree

[Kees Cook]

On Sun, Nov 25, 2018 at 4:52 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Steve,
>
> On Sun, 25 Nov 2018 18:31:40 -0600 Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > Both of those cases are intentional fallthroughs and there are
> > existing comments in the code noting the reasons for them to
> > fallthrough
> >
> > (also can see the reasoning for these in the commits which introduced
> > them from Sachin c369c9a4a7c82) and dde2356c84662)
>
> I am not questioning that :-)
>
> The gcc warning can be turned off by adding a /* fall through */
> comment at the point the fall through happens.  Kees and others are
> working on the several hundred other places that need annotating.

Right. The goal is to avoid adding any _new_ cases of this. :)

> This one just popped up.

It's already working! :) Thanks Stephen!

-Kees

-- 
Kees Cook