Re: [PATCH V12 06/20] block: rename bvec helpers

[Miguel Ojeda]

On Mon, Nov 26, 2018 at 3:20 AM Ming Lei <ming.lei@xxxxxxxxxx> wrote:
>
> We will support multi-page bvec soon, and have to deal with
> single-page vs multi-page bvec. This patch follows Christoph's
> suggestion to rename all the following helpers:
>
>         for_each_bvec
>         bvec_iter_bvec
>         bvec_iter_len
>         bvec_iter_page
>         bvec_iter_offset
>
> into:
>         for_each_segment
>         segment_iter_bvec
>         segment_iter_len
>         segment_iter_page
>         segment_iter_offset
>
> so that these helpers named with 'segment' only deal with single-page
> bvec, or called segment. We will introduce helpers named with 'bvec'
> for multi-page bvec.
>
> bvec_iter_advance() isn't renamed becasue this helper is always operated
> on real bvec even though multi-page bvec is supported.
>
> Suggested-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> ---
>  .clang-format                  |  2 +-

Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>

Cheers,
Miguel