Re: [PATCH 5/5] arch: simplify several early memory allocations

From: Christoph Hellwig
Date: Mon Nov 26 2018 - 03:21:41 EST


> static void __init *early_alloc_aligned(unsigned long sz, unsigned long align)
> {
> - void *ptr = __va(memblock_phys_alloc(sz, align));
> - memset(ptr, 0, sz);
> - return ptr;
> + return memblock_alloc(sz, align);
> }

What is the point of keeping this wrapper?

> static void __init *early_alloc(unsigned long sz)
> {
> - void *ptr = __va(memblock_phys_alloc(sz, sz));
> - memset(ptr, 0, sz);
> - return ptr;
> + return memblock_alloc(sz, sz);
> }

Same here.