Re: [PATCH V3 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

From: Viresh Kumar
Date: Mon Nov 26 2018 - 05:20:02 EST


On 26-11-18, 11:08, Daniel Lezcano wrote:
> On 26/11/2018 10:52, Quentin Perret wrote:
> > Maybe you want to test 'if (!raw_capacity || cap_parsing_failed)' at the
> > top of topology_parse_cpu_capacity() ?
>
> I prefer to update the documentation, it makes more sense than adding
> more cumbersome tests in the current code.

+1

Throwing an error and ignoring DT number completely for the capacity
are good enough in my opinion as well.

And who cares for the platforms that can't even fill the DT properly :)

--
viresh