Re: [PATCH 4.14 58/62] mtd: rawnand: atmel: fix OF child-node lookup

[Sasha Levin]

On Mon, Nov 26, 2018 at 04:39:03PM +0000, Matt Hart wrote:
> On Mon, 26 Nov 2018 at 15:16, Sasha Levin <sashal@xxxxxxxxxx> wrote:
> >
> <snip>
>
> > >>
> > >> /drivers/mtd/nand/atmel/nand-controller.c: In function
> > >> 'atmel_hsmc_nand_controller_legacy_init':
> > >> /drivers/mtd/nand/atmel/nand-controller.c:2080:11: error: implicit
> > >> declaration of function 'of_get_compatible_child'; did you mean
> > >> 'of_get_next_available_child'? [-Werror=implicit-function-declaration]
> > >>    nfc_np = of_get_compatible_child(dev->of_node, "atmel,sama5d3-nfc");
> > >
> > >Looks like of_get_compatible_child() has been introduced in 4.18, hence
> > >this error.
> > >
> > >Greg, can you drop this patch from 4.14.y?
> >
> > Interesting, none of the kernelci builds caught this? hmm
>
> They did, a few arm defconfigs failed to build because of this error.
> https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.83-64-gd81d0be7d560/

Indeed, and it was even removed from a few (but not all) of the branches
it failed on. I retract my kernelci comments :)

--
Thanks,
Sasha