Re: [PATCH v6 00/10] x86/alternative: text_poke() fixes

From: Nadav Amit
Date: Mon Nov 26 2018 - 12:46:16 EST


> On Nov 26, 2018, at 2:32 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Tue, Nov 20, 2018 at 12:35:35PM -0800, Nadav Amit wrote:
>
>> Nadav Amit (9):
>> Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"
>> x86/jump_label: Use text_poke_early() during early init
>> fork: provide a function for copying init_mm
>> x86/alternative: initializing temporary mm for patching
>> x86/alternative: use temporary mm for text poking
>> x86/kgdb: avoid redundant comparison of patched code
>> x86: avoid W^X being broken during modules loading
>> x86/jump-label: remove support for custom poker
>> x86/alternative: remove the return value of text_poke_*()
>>
>> arch/x86/include/asm/fixmap.h | 2 -
>> arch/x86/include/asm/mmu_context.h | 32 +++++
>> arch/x86/include/asm/pgtable.h | 3 +
>> arch/x86/include/asm/text-patching.h | 7 +-
>> arch/x86/kernel/alternative.c | 197 ++++++++++++++++++++-------
>> arch/x86/kernel/jump_label.c | 19 ++-
>> arch/x86/kernel/kgdb.c | 25 +---
>> arch/x86/kernel/module.c | 2 +-
>> arch/x86/mm/init_64.c | 35 +++++
>> arch/x86/xen/mmu_pv.c | 2 -
>> include/linux/filter.h | 6 +
>> include/linux/sched/task.h | 1 +
>> init/main.c | 3 +
>> kernel/fork.c | 24 +++-
>> kernel/module.c | 10 ++
>> 15 files changed, 279 insertions(+), 89 deletions(-)
>
> Thanks Nadav!
>
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

No problem, Peter.

One small request - on [02/10], since after your review the patch changed to
be the single line that you provided, I set you as a co-developer. IIUC this
requires your signed-off-by.

Thanks again for all the reviews and the help.