It's not accurate now.
On 11/26/18 10:26 AM, Ivan Khoronzhuk wrote:
On Sun, Nov 25, 2018 at 05:46:26PM -0600, Grygorii Strashko wrote:
In dual_mac mode CPSW driver uses vid1 and vid2 by default to implementSo, now it's enabled to be added via regular ndo.
dual mac mode wich are used to configure pvids for each external ports.
But, historicaly, it also adds vid0 to ALE table and sets "untag" bits for both
ext. ports. As result, it's imposible to use priority tagged packets in
dual mac mode.
Hence, drop vid0 configuration in dual mac mode as it's not required for dual
mac mode functionality and, this way, make it possible to use priority
tagged packet in dual mac mode.
I have similar change in mind, but was going to send it after
mcast/ucast, and - enabling same vlans patch...
2 things stopped me to add this:
1) Moving it to be enabled via regular call is Ok, but in dual mac mode
it causes overlaps, at least while vid deletion. So decided to wait till
same vlans series is applied.
TI driver documentation mentions this restriction
"While adding VLAN id to the eth interfaces,
same VLAN id should not be added in both interfaces which will lead to VLAN
forwarding and act as switch"
The above proposition is only to your change, only for dual-mac.
2) Wanted implement somehow similar handling for single port boards
in one patch, not only for dual mac mode. This part was not clear and
not verified completely...
So, if it's needed now, maybe better at this moment only remove
untag field? and remove vlan0 later, once other vlan changes applied.
Say:
cpsw_ale_add_vlan(cpsw->ale, cpsw->data.default_vlan,
ALE_ALL_PORTS, 0, ALE_ALL_PORTS, 0);
instead of:
cpsw_ale_add_vlan(cpsw->ale, cpsw->data.default_vlan,
ALE_ALL_PORTS, ALE_ALL_PORTS, 0, 0);
This patch affects only dual_mac mode and in this mode adding vid0 by default is
definitely make no sense in any case.
--
Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
---
drivers/net/ethernet/ti/cpsw.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
regards,
-grygorii