Re: Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

[Joey Pabalinas]

On Mon, Nov 26, 2018 at 04:27:50PM -0500, Steven Rostedt wrote:
> On Mon, 26 Nov 2018 00:02:07 -1000
> Joey Pabalinas <joeypabalinas@xxxxxxxxx> wrote:
> 
> > On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote:
> > > The static inline function task_curr_ret_stack() is unused, remove it.  
> > 
> > Just want ot make sure I understand this correctly, instead of using this
> > function, the convention now is to just directly assign `t->curr_ret_stack = -1`?
> > 
> 
> Not sure what you mean. This function would just return the value of
> curr_ret_stack, it didn't modify it.
> 
> -- Steve

Sorry for wording it a bit weird, I was mostly trying to figure out what
these functions were originally used for. The uses I found in the git
log were mostly things like:

	ret = trace_vprintk(ip, task_curr_ret_stack(current), fmt, ap);

I guess the 2nd argument for these trace functions are implicit now and
these functions are no longer needed anywhere?

-- 
Cheers,
Joey Pabalinas

Attachment: signature.asc
Description: PGP signature