Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support

[David Lechner]

On 11/26/18 1:52 AM, Roger Quadros wrote:
> From: Suman Anna <s-anna@xxxxxx>
>
> The remoteproc core creates certain standard debugfs entries,
> that does not give a whole lot of useful information for the
> PRUs. The PRU remoteproc driver is enhanced to add additional
> debugfs entries for PRU. These will be auto-cleaned up when
> the parent rproc debug directory is removed.
>
> The enhanced debugfs support adds two new entries: 'regs' and
> 'single_step'. The 'regs' dumps out the useful CTRL sub-module
> registers as well as each of the 32 GPREGs and CT_REGs registers.
> The GPREGs and CT_REGs though are printed only when the PRU is
> halted and accessible as per the IP design.

If the driver used regmap to access the CTRL I/O memory, then
'regs' wouldn't be needed since regmap already does debugfs.