Re: [PATCH] audit/filter: remove some duplicated includes

From: Paul Moore
Date: Mon Nov 26 2018 - 18:38:40 EST


On Mon, Nov 26, 2018 at 10:01 AM Yangtao Li <tiny.windzz@xxxxxxxxx> wrote:
> audit.h and fs.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> ---
> kernel/auditfilter.c | 2 --
> 1 file changed, 2 deletions(-)

See my previous comments.

> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index bf309f2592c4..6d43928a41c2 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -22,10 +22,8 @@
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> #include <linux/kernel.h>
> -#include <linux/audit.h>
> #include <linux/kthread.h>
> #include <linux/mutex.h>
> -#include <linux/fs.h>
> #include <linux/namei.h>
> #include <linux/netlink.h>
> #include <linux/sched.h>
> --
> 2.17.0
>


--
paul moore
www.paul-moore.com