Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

From: Heiko Carstens
Date: Tue Nov 27 2018 - 03:14:01 EST


On Tue, Nov 27, 2018 at 11:05:15AM +0300, Kirill A. Shutemov wrote:
> > E.g. something like the below. If there aren't any objections, I will
> > provide a proper patch with changelog, etc.
> >
> > diff --git a/kernel/fork.c b/kernel/fork.c
> > index 07cddff89c7b..d7aeec03c57f 100644
> > --- a/kernel/fork.c
> > +++ b/kernel/fork.c
> > @@ -647,8 +647,8 @@ static void check_mm(struct mm_struct *mm)
> > }
> >
> > if (mm_pgtables_bytes(mm))
> > - pr_alert("BUG: non-zero pgtables_bytes on freeing mm: %ld\n",
> > - mm_pgtables_bytes(mm));
> > + printk_once(KERN_ALERT "BUG: non-zero pgtables_bytes on freeing mm: %ld\n",
> > + mm_pgtables_bytes(mm));
>
> You can be the first user of pr_alert_once(). Don't miss a chance! ;)

I didn't expect that that one exists. ;) Will do.