Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

From: Dan Carpenter
Date: Tue Nov 27 2018 - 03:34:44 EST

On Tue, Nov 27, 2018 at 08:29:05AM +0000, Yang Xiao wrote:
> Hi,
> See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an
> off-by-one mistake in core/rtw_mlme_ext.c") for detail.
> I don't know how can you make sure that line 3254 can be true in the for
> loop.  If the condition never satisfies, then there is an off-by-one
> access in line 3267.
> If you can prove it, then the patch is unnecessary.

Ugh... Patch ef9209b642f isn't right. :(

Do you want to send a patch to change that back to the way it was. If
not then I can do it.

dan carpenter