Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails
From: Rodolfo Giometti
Date: Tue Nov 27 2018 - 03:43:51 EST
On 27/11/2018 08:34, Greg KH wrote:
On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote:
On 26/11/2018 11:24, YueHaibing wrote:
pps_register_source() has keeps error codes in a local variable,
but it does not make use of the code. This patch let it return
the errcode in case of failure.
Suggested-by: Richard Cochran <richardcochran@xxxxxxxxx>
Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
Acked-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
You are the maintainer of this file, shouldn't you be the one sending it
off to Linus or putting it in your tree somewhere?
This subsystem never had an official tree and in the past I simply acked the
code and patches was taken by you (or other maintainers) for inclusion... I know
it's not usual by it worked as is since right now!
However if you prefer having an official tree even for LinuxPPS I can do it and
then sending my pull requests to Linus! Just let me know what is better for you! :-)
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@xxxxxxxxxxxx
Linux Device Driver giometti@xxxxxxxx
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti