Re: [PATCH 1/3] media: imx274: don't declare events, they are not implemented

From: Luca Ceresoli
Date: Tue Nov 27 2018 - 04:09:13 EST

Hi Sakari,

On 27/11/18 09:38, Sakari Ailus wrote:
> Hi Luca,
> On Tue, Nov 27, 2018 at 09:34:43AM +0100, Luca Ceresoli wrote:
>> The V4L2_SUBDEV_FL_HAS_EVENTS flag should not be set, event are just
>> not implemented.
>> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
> The driver supports controls, and so control events can be subscribed and
> received by the user. Therefore I don't see a reason to remove the flag.

Thanks, good to know.

Would it be worth adding a note where V4L2_SUBDEV_FL_HAS_EVENTS is
#defined, to make this clear?