Re: [RFC PATCH 3/3] mm, proc: report PR_SET_THP_DISABLE in proc

From: Michal Hocko
Date: Tue Nov 27 2018 - 08:17:14 EST


On Mon 26-11-18 17:33:32, William Kucharski wrote:
>
>
> This determines whether the page can theoretically be THP-mapped , but
> is the intention to also check for proper alignment and/or preexisting
> PAGESIZE page cache mappings for the address range?

This is only about the process wide flag to disable THP. I do not see
how this can be alighnement related. I suspect you wanted to ask in the
smaps patch?

> I'm having to deal with both these issues in the text page THP
> prototype I've been working on for some time now.

Could you be more specific about the issue and how the alignment comes
into the game? The only thing I can think of is to not report VMAs
smaller than the THP as eligible. Is this what you are looking for?
--
Michal Hocko
SUSE Labs