Re: [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

[Wang, Haiyue]

[Resend for wrong reply HTML format mail]

Great check for making kcs_bmc module be more stable and handle things gracefully.

My tag if needed.
     Reviewed-by: Haiyue Wang<haiyue.wang@xxxxxxxxxxxxxxx>

å 2018-11-27 21:36, Corey Minyard åé:
> On 11/21/18 9:08 AM, Nicholas Mc Guire wrote:
> > devm_kasprintf() may return NULL if internal allocation failed so this
> > assignment is not safe. Moved the error exit path and added the !NULL
> > which then allows the devres manager to take care of cleanup.
>
>
> Added the original author. This looks correct to me, I've included 
> it, but I would
> like Haiyue to comment, if possible.
>
> Thanks,
>
> -corey
>
>
> > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> > Fixes: cd2315d471f4 ("ipmi: kcs_bmc: don't change device name")