Re: [PATCH v2 2/7] drm/msm/dsi: 14nm PHY: Get ref clock from the DT

From: Doug Anderson
Date: Wed Nov 28 2018 - 00:57:05 EST


On Mon, Nov 26, 2018 at 3:12 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> Get the ref clock of the PHY from the device tree instead of
> hardcoding its name and rate.

In the case of the 14nm PHY I think it's OK that you break
compatibility with old device tree files (as this patch does) since
the 14nm support was added sorta recently and "git grep" shows no
users in linuxnext. You should note that you're breaking
compatibility with old DTS files in the commit message here so that if
someone crawls out of the woodwork it will be easy for them to
understand what happened.

> + pll_14nm->vco_ref_clk = devm_clk_get(&pdev->dev, "ref");
> + if (IS_ERR(pll_14nm->vco_ref_clk)) {
> + ret = PTR_ERR(pll_14nm->vco_ref_clk);
> + if (ret != EPROBE_DEFER)

Shouldn't this check against -EPROBE_DEFER, not against EPROBE_DEFER?
It's negative. Presumably this same feedback needs to be applied to
the whole patch series.

Other than that this looks good to me and you can feel free to add my
Reviewed-by tag FWIW.