Re: [PATCH] sis5513: fix potential use after free

From: Christoph Hellwig
Date: Wed Nov 28 2018 - 02:05:31 EST

On Wed, Nov 28, 2018 at 08:55:26AM +0800, Pan Bian wrote:
> The function sis_find_family drops lpc_bridge reference via pci_dev_put,
> however, after that, field lpc_bridge->revision is read. This may result
> in a use after free bug. The patch moves the put operation after the
> condition check.
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>