Re: [PATCH v3 0/2] panic: Add options to dump system info on panic

From: Steven Rostedt
Date: Wed Nov 28 2018 - 09:12:06 EST

On Wed, 28 Nov 2018 17:54:00 +0800
Feng Tang <feng.tang@xxxxxxxxx> wrote:

> Kernel panic issues are always painful to debug, partially
> because it's not easy to get enough information of the
> context when panic happens.
> And we have ramoops and kdump for that, while this commit
> tries to provide a easier way to show the system info by adding
> a cmdline parameter, referring some idea from sysrq handler.
> The patches have been used by us and did help on solving some nasty
> panic cases.
> Please help to review, thanks!

Looks fine to me.

Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Although, I still wonder if we should add a comment stating that bit 4
is the same as ftrace_dump_on_oops.

-- Steve