Re: [PATCH 1/1] ASoC: pcm3168a: Don't disable pcm3168a when CONFIG_PM defined

[Mark Brown]

On Wed, Nov 28, 2018 at 09:26:12PM +0900, jiada_wang@xxxxxxxxxx wrote:
> From: Jiada Wang <jiada_wang@xxxxxxxxxx>
> 
> pcm3168 codec support runtime_[resume|suspend], whenever it
> is not active, it enters suspend mode, and it's clock and regulators
> will be disabled. so there is no need to disable them again in
> remove callback.  Otherwise we got following kernel warnings,
> when unload pcm3168a driver
> 
> [  222.257514] unbalanced disables for amp-en-regulator
> [  222.262526] ------------[ cut here ]------------
> [  222.267158] WARNING: CPU: 0 PID: 2423 at drivers/regulator/core.c:2264 _regulator_disable+0x28/0x108
> [  222.276291] Modules linked in:
> [  222.279343]  snd_soc_pcm3168a_i2c(-)

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative then it's
usually better to pull out the relevant sections.

Attachment: signature.asc
Description: PGP signature